SW location.

Datenschutzerklärung: klick mich
News zu den Änderungen durch die DSGVO auf unserer Website
Einstellungsmöglichkeiten zur Privatsphäre finden Sie in Ihren Einstellungen
Einen maschinenlesbaren Export Ihrer Daten können Sie in Ihrem Profil anfordern
  • Hello, a suggestion :).


    Idk if you can, with the package installer setup. However the SW should be in root, it is running in its current form, however it will not work on mobile like that, and fails LH.


    Woltlab makes a similar error. With their default Favicon info sections. It needs to be in root, for the manifest to read properly.


    I not sure if this will allow the notifs to work on mobile or not, but as of now they do not. And I will get to testing here later, but it will allow pwa, and the current setup makes you choose PWA or this Push.


    _____________________________________________________________________


    Update:

    I was wrong, apparently your SW location is just fine, I thought it would override root SW, it does not, it adds to it, due to your nav call.


    Also, just tested this, on my PWA, works Perfectly, except 2 issues.


    1. On both, the browser and the PWA, the notification gives a header logo, (Id prefer it didn't, at all personally) which is fine for most, and I would be fine with, except the image on my site is extremely blown out, and cuts the box its supposed to reside in. It is also like this in mobile, and makes the notif, extremely large (like half the phone screen lol). It does the same on your site, and you see like Myst and thats it. I would suggest, allowing that to be resized, and/or turned off in the settings. I can likely do that for mine for now, but for future less techy people :).


    2. The link given, on the notif, is shown as [URL:Mysite-notiftype] Instead of just a link, Also, if you didnt know I dont think that link needs to be description for the notif to take to page. As there is no link on stock Woltlabs notifs. So maybe just a description of the notif type? Ill check into that for you as well, and see what I can do, about fixing it.


    Not really a suggestion for the plugin, but just a so you know. or maybe for future plug in :).

    This works fully with PWAs, which could be a selling point, to do that is easy. You will need a Root SW, even if its blank, as your Register is on demand, but you can register a Blank SW, and yours will overwrite allowing full PWA, prior to Notifs. So basically just need a blank file named SW.JS in root, and it registered, and if you have not tried PWA yet, you have to make a new manifest. You may be able to do it, with woltlabs in the favicon folders, but I had nothing but issues, so overwrite theirs, in Templates manifest link, to mine.


    Oh and thank you so much for this plugin. You are a rockstar!

  • Did you test this with Alpha 2?

    The banner image should be removed by default and the URL stuff should be filtered.

    I'll read your post later again, I'm just on my way home at the moment. ;)

    I did test on Alpha 2, alpha 1 did nothing for me lol.

    Its not all notifications apparently. The test on my site and yours shows a banner, that is a super scaled up image thats cut off for me (as I dont use the header I put the mobile one in there to stop Woltlab software complaining lol) and for yours its just cut off.

    The test does not show a link, however conversations does. Sadly it appears I cannot SS browser notifs. I will get my phone and take a picture if you want?


    EDIT: Okay, so in my instance, the banner shows on the "test" push. No links show on that (Aside from the small one that is just a home page link). For the conversation one, it has the link [URL:Bunch of Stuff] in the Description of notification.


    On alpha 1, the "Enable Push and Test Push" didn't show up for me.



    Another suggestion, if this is possible? Is there a way, that you could use the browser notification flag to flag your allow class? Maybe just turn push on by default and allow the browser to specify whether its allowed or not? It is kind of hard to find for non techies lol, and browser and phone ask for an allow and people will then assume they are on.